Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RequestInformation by removing GetType, prefer typeof(T) #184

Merged
merged 8 commits into from
Feb 1, 2024
Merged

Fix RequestInformation by removing GetType, prefer typeof(T) #184

merged 8 commits into from
Feb 1, 2024

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Jan 29, 2024 •
edited by baywet
Loading

@IEvangelist IEvangelist mentioned this pull request Jan 29, 2024
Closed
This was referenced Jan 30, 2024
Merged
Merged
baywet
baywet requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. A couple of remarks

src/serialization/KiotaSerializer.Deserialization.cs Show resolved Hide resolved
src/serialization/KiotaSerializer.Serialization.cs Outdated Show resolved Hide resolved
src/RequestInformation.cs Outdated Show resolved Hide resolved
src/Microsoft.Kiota.Abstractions.csproj Outdated Show resolved Hide resolved
@IEvangelist IEvangelist mentioned this pull request Jan 30, 2024
Merged
@eerhardt eerhardt mentioned this pull request Jan 31, 2024
Closed
baywet
baywet requested changes Jan 31, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably the final comment on my side

src/RequestInformation.cs Outdated Show resolved Hide resolved
baywet
baywet approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@andrueastman andrueastman merged commit 759bdcd into microsoft:main Feb 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eerhardt eerhardt eerhardt left review comments

@andrueastman andrueastman andrueastman approved these changes

@baywet baywet baywet approved these changes

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@zengin zengin Awaiting requested review from zengin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Native AOT warnings
4 participants
@IEvangelist @andrueastman @baywet @eerhardt